[PATCH] Add --root-device to upgrade command

Alexander Todorov atodorov at redhat.com
Fri Dec 12 09:34:55 UTC 2008


Chris Lumens wrote:
> Thanks for fetching pykickstart first and following all my recent
> stylistic changes (like the kwargs.get stuff)!
> 
> However, you don't want to add this option to FC3_Upgrade.  You'll want
> to make a new F11_Upgrade object that inherits from FC3_Upgrade, then
> modify the appropriate commandMap entry in handlers/control.py to
> reference the F11_Upgrade object.  Then the F11_Upgrade class gets the
> new option and the FC3_Upgrade class goes untouched.
> 

I don't fully understand the reasoning behind this because the new features are 
backwards compatible. Anyway I've moved them into a separate class and updated 
the control map.

I only don't understand what's the purpose of:

removedKeywords = KickstartCommand.removedKeywords
removedAttrs = KickstartCommand.removedAttrs


in FC3_Upgrade (and other classes) and not sure if I need it in the new class.

Btw as pointed in anaconda-devel-list it will be necessary to support UUID and 
LABEL when specifying the device but the pykickstart bits don't need to change. 
Just change synopsis to:

upgrade [--root-device=DEV] where

DEV=/dev/sda1               or
DEV=UUID=abcd-fdeb-....     or
DEV=LABEL=/

This is consistent with /etc/fstab and other places and the calling application 
(Anaconda) will need to take care of finding the correct device.

Regards,
Alexander.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pykickstart_upgrade.patch
Type: text/x-patch
Size: 2601 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/kickstart-list/attachments/20081212/4278bbfe/attachment.bin>


More information about the Kickstart-list mailing list