Fwd: [PATCH] Corrected return value of FC6_Iscsi parse method; Added iscsi, ignoredisk, langsupport test cases.

Chris Lumens clumens at redhat.com
Mon Feb 9 18:44:31 UTC 2009


> +class FC3_TestCase(CommandTest):
> +    def runTest(self):
> +        # pass
> +        self.assert_parse("ignoredisk --drives=sda", "ignoredisk --drives=sda\n")
> +        self.assert_parse("ignoredisk --drives=sda,sdb", "ignoredisk --drives=sda,sdb\n")
> +        # empty
> +        self.assert_parse("ignoredisk", "")

I'm going to make --drives required for FC3 but not F8, so I'll change
this to be a failing test.

> +class FC5_TestCase(FC3_TestCase):
> +    def runTest(self):
> +        # pass
> +        # deprecated command
> +        pass

This shouldn't be necessary here.  Eventually, we need to have tests for
the parser that'll check that commands were removed or deprecated.
However for now, this isn't the level to be adding these sorts of
checks.

Other than that, looks fine.  I'll make the modifications I outlined
above and commit.  Thanks.

- Chris




More information about the Kickstart-list mailing list