<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">
Hi Josh,
<div class=""><br class="">
</div>
<div class="">When I run kpatch-build tool for the memnfo-string.patch on our 3.4 kernel, I got an error of </div>
<div class=""><br class="">
</div>
<div class=""><span class="Apple-tab-span" style="white-space:pre"></span>meminfo.o: function meminfo_proc_show has no fentry call, unable to patch </div>
<div class=""><br class="">
<div class="">It seems the fentry support is added in d57c5d51a30152f3175d2344cb6395f08bf8ee0c, which I didn’t backport yet. Should I backport it and maybe some other commits? </div>
<div class=""><br class="">
</div>
<div class="">Or there is a kpatch version which only use mcount instead of fentry?</div>
<div class=""><br class="">
</div>
<div class=""><br class="">
</div>
<div class="">
<div class="">commit d57c5d51a30152f3175d2344cb6395f08bf8ee0c</div>
<div class="">Author: Steven Rostedt <<a href="mailto:srostedt@redhat.com" class="">srostedt@redhat.com</a>></div>
<div class="">Date: Wed Feb 9 13:32:18 2011 -0500</div>
<div class=""><br class="">
</div>
<div class=""> ftrace/x86: Add support for -mfentry to x86_64</div>
</div>
<div class=""><br class="">
</div>
<div class=""><br class="">
</div>
<div class=""><br class="webkit-block-placeholder">
</div>
<div class="">
<div style="color: rgb(0, 0, 0); letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">
<div class="">Thanks</div>
<div class="">Michael</div>
<div class=""><br class="">
</div>
</div>
<br class="Apple-interchange-newline">
<br class="Apple-interchange-newline">
</div>
<br class="">
<div>
<blockquote type="cite" class="">
<div class="">On Jan 27, 2016, at 7:55 PM, Josh Poimboeuf <<a href="mailto:jpoimboe@redhat.com" class="">jpoimboe@redhat.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Michael,</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">The
06aeaaeabf69da4a3e86df532425640f51b01cef commit seems to be just a</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">cosmetic
change so I don't think you need it (unless it's a dependency</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">for
another needed change).</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Otherwise
I'm not sure what else you need.</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">On
Wed, Jan 27, 2016 at 04:16:39AM +0000, Michael Liu (zuwliu) wrote:</span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<blockquote type="cite" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
Hi Josh,<br class="">
<br class="">
Wondering to which stage of ftrace I need to backport to 3.4 kernel? I already back ported commits:<br class="">
<br class="">
08f6fba503111e0336f2b4d6915a4a18f9b60e51 (ftrace/x86: Add separate function to save regs)<br class="">
647664eaf4033501739ac1f42dd52ce8c9266ccc (ftrace: add ftrace_set_filter_ip() for address based filter)<br class="">
<br class="">
Now I can compile kmod/core KLM in kpatch on 3.4 kernel. Wondering do I need also backport the commit of<br class="">
<br class="">
06aeaaeabf69da4a3e86df532425640f51b01cef (ftrace: Move ARCH_SUPPORTS_FTRACE_SAVE_REGS in Kconfig)<br class="">
<br class="">
to make kpatch really work on 3.4 kernel?<br class="">
<br class="">
Really appreciate your help!<br class="">
<br class="">
Thanks<br class="">
Michael<br class="">
<br class="">
<br class="">
<br class="">
<br class="">
On Jan 20, 2016, at 7:39 AM, Josh Poimboeuf <<a href="mailto:jpoimboe@redhat.com" class="">jpoimboe@redhat.com</a><<a href="mailto:jpoimboe@redhat.com" class="">mailto:jpoimboe@redhat.com</a>>> wrote:<br class="">
<br class="">
On Tue, Jan 19, 2016 at 04:15:10PM +0000, Michael Liu (zuwliu) wrote:<br class="">
I joined the member and try to send it again.<br class="">
<br class="">
Hello Kpatch,<br class="">
<br class="">
I’m in a project which requires running kpatch on our 3.4 kernel, wondering how much effort is needed to do so?<br class="">
<br class="">
We currently using GCC 4.6.3, but I think we can move to GCC 4.8 if needed. However we cannot move our kernel to 3.9.<br class="">
<br class="">
In 3.4 kernel I saw there is already ftrace, although there is no CONFIG_DYNAMIC_FTRACE_WITH_REGS feature. Wondering whether CONFIG_DYNAMIC_FTRACE_WITH_REGS is the only feature missing on 3.4 to support kpatch? Are there other things we need to backport to
run kpatch on 3.4 kernel?<br class="">
<br class="">
Thank you for your time!<br class="">
<br class="">
Hi Michael,<br class="">
<br class="">
CONFIG_DYNAMIC_FTRACE_WITH_REGS is the biggest required feature I know<br class="">
about that's missing on 3.4.<br class="">
<br class="">
Also, there are at least some minor kernel API differences that affect<br class="">
the kpatch core module, described here:<br class="">
<br class="">
<a href="https://github.com/dynup/kpatch/issues/257" class="">https://github.com/dynup/kpatch/issues/257</a><br class="">
<br class="">
GCC 4.6 may have issues:<br class="">
<br class="">
https://github.com/dynup/kpatch/issues/246#issuecomment-46615292<br class="">
<br class="">
Those are just the problems I know about. You might run into other<br class="">
issues...<br class="">
<br class="">
--<br class="">
Josh<br class="">
<br class="">
</blockquote>
<br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">--<span class="Apple-converted-space"> </span></span><br style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class="">
<span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Josh</span></div>
</blockquote>
</div>
<br class="">
</div>
</body>
</html>