[Libguestfs] [PATCH] Cleanup whitespace warnings in Lib.pm

Matthew Booth mbooth at redhat.com
Mon Aug 3 13:07:03 UTC 2009


On 03/08/09 13:59, Jim Meyering wrote:
> Richard W.M. Jones wrote:
>
>> On Mon, Aug 03, 2009 at 11:50:29AM +0100, Matthew Booth wrote:
>>> ---
>> ACK.  Purely whitespace changes, or changes which fix typos, or add
>> documentation shouldn't really need acking.
>
> How do you feel about a no-TABs-for-indentation rule?
> (like the one libvirt uses)

I have had 'set expandtab' in my .vimrc for years :)

I would vote for this. Indentation with tabs sometimes breaks (e.g. if 
somebody has reconfigured tabs in their editor), whereas indentation 
with spaces never breaks.

Matt
-- 
Matthew Booth, RHCA, RHCSS
Red Hat Engineering, Virtualisation Team

M:       +44 (0)7977 267231
GPG ID:  D33C3490
GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490




More information about the Libguestfs mailing list