[Libguestfs] Re: [PATCH libguestfs 20/23] mount.c (do_mount): make a local "const" to match parameter's type

Jim Meyering jim at meyering.net
Wed Aug 12 18:00:41 UTC 2009


Jim Meyering wrote:
> From: Jim Meyering <meyering at redhat.com>
>
> ---
>  daemon/mount.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/daemon/mount.c b/daemon/mount.c
> index 89bef34..9ccb37b 100644
> --- a/daemon/mount.c
> +++ b/daemon/mount.c
> @@ -106,7 +106,7 @@ int
>  do_umount (const char *pathordevice)
>  {
>    int freeit = 0, r;
> -  char *buf;
> +  const char *buf;
>    char *err;

I've just noticed that is bogus, and should be merged with the later,

    do_umount: don't use RESOLVE_DEVICE anymore

change that rewrites the function.
Also, I got the function name wrong in the subject: should be
s/mount/umount/.




More information about the Libguestfs mailing list