[Libguestfs] [virt-v2v] "make distcheck" now passes
Jim Meyering
jim at meyering.net
Fri Aug 21 12:28:30 UTC 2009
Richard W.M. Jones wrote:
> On Fri, Aug 21, 2009 at 01:44:50PM +0200, Jim Meyering wrote:
>> -AM_GNU_GETTEXT_VERSION([0.14])
>> +AM_GNU_GETTEXT_VERSION([0.15])
>
> Gettext on RHEL 5.4 Beta is version 0.14, so I would be wary about
> making such a change, since it means you won't be able to compile this
> on RHEL.
>
>> virt-v2v.1: virt-v2v.pl
>> + rm -f $@-t $@
>> $(POD2MAN) \
>> --section 1 \
>> -c "Virtualization Support" \
>> --release "$(PACKAGE_NAME)-$(PACKAGE_VERSION)" \
>> - $< > $@
>> + $< > $@-t && mv $@-t $@
>
> Why does this use && rather than just a rule on the following line?
Either way works.
I prefer the above form, to keep the conceptual "redirect-to-target"
idiom all on one line. Then, it's harder for someone to accidentally
disrupt it by inserting a new rule between them.
More information about the Libguestfs
mailing list