[Libguestfs] [PATCH libguestfs 9/9] fish/: enable -Werror and all of gcc's warning options

Jim Meyering jim at meyering.net
Fri Aug 21 13:44:04 UTC 2009


Richard W.M. Jones wrote:
> On Fri, Aug 21, 2009 at 03:28:19PM +0200, Jim Meyering wrote:
>> From: Jim Meyering <meyering at redhat.com>
>>
>> * fish/Makefile.am: Use $(WARN_CFLAGS) $(WERROR_CFLAGS).
>> ---
>>  fish/Makefile.am |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/fish/Makefile.am b/fish/Makefile.am
>> index 5bf3fbd..94bf757 100644
>> --- a/fish/Makefile.am
>> +++ b/fish/Makefile.am
>> @@ -51,8 +51,8 @@ BUILT_SOURCES = \
>>  guestfish_CFLAGS = \
>>  	-I$(top_srcdir)/src -I$(top_builddir)/src \
>>  	-I$(top_srcdir)/fish -I$(top_builddir)/fish \
>> -	-Wall \
>> -	-DGUESTFS_DEFAULT_PATH='"$(libdir)/guestfs"'
>> +	-DGUESTFS_DEFAULT_PATH='"$(libdir)/guestfs"' \
>> +	$(WARN_CFLAGS) $(WERROR_CFLAGS)
>>
>>  guestfish_LDADD = $(top_builddir)/src/libguestfs.la $(LIBREADLINE)
>>
>> --
>> 1.6.4.378.g88f2f
>
> ACK (to the whole patch series).

Thanks. pushed




More information about the Libguestfs mailing list