[Libguestfs] [PATCH libguestfs 2/5] guestfish: write --help to stdout, use gnulib's progname module

Richard W.M. Jones rjones at redhat.com
Mon Aug 24 15:58:20 UTC 2009


On Mon, Aug 24, 2009 at 05:46:03PM +0200, Jim Meyering wrote:
> There are a couple of compelling arguments for making the
> change in general:
> 
>   - testing and reproducibility: with the change, all diagnostics
>     start with the constant string, "program_name: ".
>     Otherwise, you'll have most that are that way, yet a few
>     that then start with an absolute directory name and end in
>     "/.libs/lt-program_name: ".  Worse still, in some environments,
>     that leading directory name will vary from run to run depending
>     on mount point names.
> 
>   - overall uniformity.  in building the tools and testing them, we've
>     seen how much output you may have to wade through when diagnosing a
>     problem.  If we ensure that all diagnostics start with "program_name: "
>     it's that much easier to be sure that a quick use of grep finds all
>     error messages.
> 
> If it will make it easier to accept, I will add some small tests
> that verify the expected behavior.

Well OK.  What's the final version of this patch (not incremental)?

Rich.

-- 
Richard Jones, Emerging Technologies, Red Hat  http://et.redhat.com/~rjones
New in Fedora 11: Fedora Windows cross-compiler. Compile Windows
programs, test, and build Windows installers. Over 70 libraries supprt'd
http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw




More information about the Libguestfs mailing list