[Libguestfs] [PATCH] appliance: Ignore unreadable dbus helper programs.
Richard W.M. Jones
rjones at redhat.com
Wed Dec 16 11:10:04 UTC 2009
This avoids an error where the appliance cannot start up because this
dbus helper script (which is never used) is unreadable by non-root.
Why do we have unreadable binaries in Fedora at all? You may wonder:
https://www.redhat.com/archives/fedora-devel-list/2009-October/msg00987.html
Maintaining a blacklist like this is generally a bad thing. We should
change this code so it automatically detects when a binary is going to
be unreadable. However I'd like to keep an eye on this list so we
don't blacklist something which is necessary for the appliance to run.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://et.redhat.com/~rjones/libguestfs/
See what it can do: http://et.redhat.com/~rjones/libguestfs/recipes.html
-------------- next part --------------
>From 795cf46a03bbe6ca0cbbeb951b8aceaf6e29eaca Mon Sep 17 00:00:00 2001
From: Richard Jones <rjones at redhat.com>
Date: Wed, 16 Dec 2009 11:04:10 +0000
Subject: [PATCH] appliance: Ignore unreadable dbus helper programs.
---
appliance/make.sh.in | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/appliance/make.sh.in b/appliance/make.sh.in
index 37e1893..b3cbe92 100755
--- a/appliance/make.sh.in
+++ b/appliance/make.sh.in
@@ -96,6 +96,8 @@ if [ "@DIST@" = "REDHAT" ]; then
/usr/sbin/groupmems \
/sbin/unix_update \
/usr/sbin/tcpd \
+ /lib/dbus-1/dbus-daemon-launch-helper \
+ /lib64/dbus-1/dbus-daemon-launch-helper \
$(cd initramfs && echo usr/sbin/glibc_post_upgrade.*)
# Kernel modules take up nearly half of the image. Only include ones
--
1.6.5.2
More information about the Libguestfs
mailing list