[Libguestfs] [PATCH] Differentiate 'distro' and 'distrofamily' in Sys::Guestfs::Lib

Matthew Booth mbooth at redhat.com
Fri Jul 17 11:41:04 UTC 2009


On 17/07/09 12:21, Richard W.M. Jones wrote:
> On Fri, Jul 17, 2009 at 12:06:31PM +0100, Matthew Booth wrote:
>> On 17/07/09 11:21, Daniel P. Berrange wrote:
>>> IMHO doing this is a big mistake. This is what we did for virt-install
>>> and hugely regret it. Things just don't fall into a nice hierarchy. We
>>> are now looking at doing a flat list of distros + tagging/categorization
>>> relationships to be defined.
>>>
>>>    http://www.redhat.com/archives/et-mgmt-tools/2009-June/msg00018.html
>> Thanks, Dan.
>>
>> What problems did you hit? I'm inclined to think I might get away with
>> it for virt-v2v because we also have so much other additional info about
>> the system. So far, 'redhat' pretty much means it uses rpm rather than
>> anything else.
>
> How about instead of "distrofamily" we add flags to tell us what
> we actually want to know:
>
>    uses_rpm
>    uses_dpkg

or, as this would be single-os specific:

package_management=rpm
package_management=dpkg

My only concern about that scheme is that at this point we have little 
idea about what we need to know. I guess it won't be too hard to add it 
as we go along.

I can make this change on Monday morning if you like.

Matt
-- 
Matthew Booth, RHCA, RHCSS
Red Hat Engineering, Virtualisation Team

M:       +44 (0)7977 267231
GPG ID:  D33C3490
GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490




More information about the Libguestfs mailing list