[Libguestfs] [PATCH] Debian: Use /bin/bash as the shell for regression test scripts.

Richard W.M. Jones rjones at redhat.com
Wed Nov 4 16:38:46 UTC 2009


Another fix revealed by testing this on Debian.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming blog: http://rwmj.wordpress.com
Fedora now supports 80 OCaml packages (the OPEN alternative to F#)
http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora
-------------- next part --------------
>From 4f4880303693bc2e55ce431e87302098654b7f03 Mon Sep 17 00:00:00 2001
From: Richard Jones <rjones at debian5x64.home.annexia.org>
Date: Wed, 4 Nov 2009 16:32:50 +0000
Subject: [PATCH] Debian: Use /bin/bash as the shell for regression test scripts.

/bin/sh on Debian is a minimal shell called 'dash' which doesn't
support some features we need such as the particular 'function'
syntax used by regressions/test-stringlist.sh, and therefore
this script was failing on Debian.

Change all of these scripts to use #!/bin/bash explicitly to avoid
these sorts of problems.
---
 regressions/rhbz503169c10.sh                       |    2 +-
 regressions/rhbz503169c13.sh                       |    2 +-
 regressions/test-bootbootboot.sh                   |    2 +-
 .../test-cancellation-download-librarycancels.sh   |    2 +-
 .../test-cancellation-upload-daemoncancels.sh      |    2 +-
 regressions/test-find0.sh                          |    2 +-
 regressions/test-qemudie-killsub.sh                |    2 +-
 regressions/test-qemudie-launchfail.sh             |    2 +-
 regressions/test-qemudie-midcommand.sh             |    2 +-
 regressions/test-qemudie-synch.sh                  |    2 +-
 regressions/test-read_file.sh                      |    2 +-
 regressions/test-remote.sh                         |    2 +-
 regressions/test-reopen.sh                         |    2 +-
 regressions/test-stringlist.sh                     |    2 +-
 14 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/regressions/rhbz503169c10.sh b/regressions/rhbz503169c10.sh
index 8813c05..91284e0 100755
--- a/regressions/rhbz503169c10.sh
+++ b/regressions/rhbz503169c10.sh
@@ -1,4 +1,4 @@
-#!/bin/sh -
+#!/bin/bash -
 # libguestfs
 # Copyright (C) 2009 Red Hat Inc.
 #
diff --git a/regressions/rhbz503169c13.sh b/regressions/rhbz503169c13.sh
index b6b4b94..7bace82 100755
--- a/regressions/rhbz503169c13.sh
+++ b/regressions/rhbz503169c13.sh
@@ -1,4 +1,4 @@
-#!/bin/sh -
+#!/bin/bash -
 # libguestfs
 # Copyright (C) 2009 Red Hat Inc.
 #
diff --git a/regressions/test-bootbootboot.sh b/regressions/test-bootbootboot.sh
index 4586aff..5be15d2 100755
--- a/regressions/test-bootbootboot.sh
+++ b/regressions/test-bootbootboot.sh
@@ -1,4 +1,4 @@
-#!/bin/sh -
+#!/bin/bash -
 # libguestfs
 # Copyright (C) 2009 Red Hat Inc.
 #
diff --git a/regressions/test-cancellation-download-librarycancels.sh b/regressions/test-cancellation-download-librarycancels.sh
index 73c5469..7b59b7e 100755
--- a/regressions/test-cancellation-download-librarycancels.sh
+++ b/regressions/test-cancellation-download-librarycancels.sh
@@ -1,4 +1,4 @@
-#!/bin/sh -
+#!/bin/bash -
 # libguestfs
 # Copyright (C) 2009 Red Hat Inc.
 #
diff --git a/regressions/test-cancellation-upload-daemoncancels.sh b/regressions/test-cancellation-upload-daemoncancels.sh
index c56b1c2..835c3bb 100755
--- a/regressions/test-cancellation-upload-daemoncancels.sh
+++ b/regressions/test-cancellation-upload-daemoncancels.sh
@@ -1,4 +1,4 @@
-#!/bin/sh -
+#!/bin/bash -
 # libguestfs
 # Copyright (C) 2009 Red Hat Inc.
 #
diff --git a/regressions/test-find0.sh b/regressions/test-find0.sh
index 4849b64..e2bd89e 100755
--- a/regressions/test-find0.sh
+++ b/regressions/test-find0.sh
@@ -1,4 +1,4 @@
-#!/bin/sh -
+#!/bin/bash -
 # libguestfs
 # Copyright (C) 2009 Red Hat Inc.
 #
diff --git a/regressions/test-qemudie-killsub.sh b/regressions/test-qemudie-killsub.sh
index 9848ebf..14b4688 100755
--- a/regressions/test-qemudie-killsub.sh
+++ b/regressions/test-qemudie-killsub.sh
@@ -1,4 +1,4 @@
-#!/bin/sh -
+#!/bin/bash -
 # libguestfs
 # Copyright (C) 2009 Red Hat Inc.
 #
diff --git a/regressions/test-qemudie-launchfail.sh b/regressions/test-qemudie-launchfail.sh
index 7da1c35..15e62fb 100755
--- a/regressions/test-qemudie-launchfail.sh
+++ b/regressions/test-qemudie-launchfail.sh
@@ -1,4 +1,4 @@
-#!/bin/sh -
+#!/bin/bash -
 # libguestfs
 # Copyright (C) 2009 Red Hat Inc.
 #
diff --git a/regressions/test-qemudie-midcommand.sh b/regressions/test-qemudie-midcommand.sh
index 2aca922..92a4c68 100755
--- a/regressions/test-qemudie-midcommand.sh
+++ b/regressions/test-qemudie-midcommand.sh
@@ -1,4 +1,4 @@
-#!/bin/sh -
+#!/bin/bash -
 # libguestfs
 # Copyright (C) 2009 Red Hat Inc.
 #
diff --git a/regressions/test-qemudie-synch.sh b/regressions/test-qemudie-synch.sh
index 96e879d..5932fef 100755
--- a/regressions/test-qemudie-synch.sh
+++ b/regressions/test-qemudie-synch.sh
@@ -1,4 +1,4 @@
-#!/bin/sh -
+#!/bin/bash -
 # libguestfs
 # Copyright (C) 2009 Red Hat Inc.
 #
diff --git a/regressions/test-read_file.sh b/regressions/test-read_file.sh
index 3b9c6ef..71b8957 100755
--- a/regressions/test-read_file.sh
+++ b/regressions/test-read_file.sh
@@ -1,4 +1,4 @@
-#!/bin/sh -
+#!/bin/bash -
 # libguestfs
 # Copyright (C) 2009 Red Hat Inc.
 #
diff --git a/regressions/test-remote.sh b/regressions/test-remote.sh
index 783dd6e..ed02ccf 100755
--- a/regressions/test-remote.sh
+++ b/regressions/test-remote.sh
@@ -1,4 +1,4 @@
-#!/bin/sh -
+#!/bin/bash -
 # libguestfs
 # Copyright (C) 2009 Red Hat Inc.
 #
diff --git a/regressions/test-reopen.sh b/regressions/test-reopen.sh
index 7901754..90774c9 100755
--- a/regressions/test-reopen.sh
+++ b/regressions/test-reopen.sh
@@ -1,4 +1,4 @@
-#!/bin/sh -
+#!/bin/bash -
 # libguestfs
 # Copyright (C) 2009 Red Hat Inc.
 #
diff --git a/regressions/test-stringlist.sh b/regressions/test-stringlist.sh
index 0b0c476..06b5bc2 100755
--- a/regressions/test-stringlist.sh
+++ b/regressions/test-stringlist.sh
@@ -1,4 +1,4 @@
-#!/bin/sh -
+#!/bin/bash -
 # libguestfs
 # Copyright (C) 2009 Red Hat Inc.
 #
-- 
1.6.5.2



More information about the Libguestfs mailing list