[Libguestfs] Re: [PATCH 4/5 version 2] New tool: virt-tar

[Richard W.M. Jones]

On Tue, Oct 20, 2009 at 09:26:56AM +0100, Matthew Booth wrote:
> On 19/10/09 18:14, Richard W.M. Jones wrote:
>>>> +die __"multiboot operating systems are not supported by virt-edit" if @roots>   1;
>>>
>>> It's virt-tar, not virt-edit ;)
>>
>> And fixed this one.
>>
>> New patch attached.
>
> No library function? That's a non-trivial amount of duplicate code.

Trouble is, where do we put the library function?

If we share it somewhere then we add cohesion between these
tools which are currently completely separate programs.

We could add it to Sys::Guestfs::Lib, but it doesn't fit very well.
(And the code isn't exactly duplicated anyway, but different for
each tool).

I think it's fine as it is for now ...

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://et.redhat.com/~rjones/libguestfs/
See what it can do: http://et.redhat.com/~rjones/libguestfs/recipes.html