[Libguestfs] [PATCH REBASED] Remove main loop

Matthew Booth mbooth at redhat.com
Mon Sep 14 11:44:15 UTC 2009


On 14/09/09 12:10, Richard W.M. Jones wrote:
> This is the only patch I currently have outstanding.  No changes from
> the previous posting, except I rebased it against the head of git.

I'm still reviewing this (and probably will be for a while). I have a 
high-level observation at this stage, though. Several error paths in 
this code (and the previous code, too) would be a whole lot simpler if 
LAUNCH and CANCEL were turned into real protocol messages, and receive 
file was terminated with ACK. This would also simplify review.

Matt
-- 
Matthew Booth, RHCA, RHCSS
Red Hat Engineering, Virtualisation Team

M:       +44 (0)7977 267231
GPG ID:  D33C3490
GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490




More information about the Libguestfs mailing list