[Libguestfs] hivex: hivexsh dependency on libncurses?

[Richard W.M. Jones]

On Sat, Apr 03, 2010 at 10:22:29AM +0100, TJ wrote:
> Hopefully this is my last issue raised as a result of the Debian
> packaging effort!
> 
> I see a warning from debhelper which suggests the linked library
> "libncurses" may actually be no longer required by "hivexsh". Is this
> so, or is it in preparation for some future use of the library?
> 
> dpkg-shlibdeps: warning: dependency on libncurses.so.5 could be avoided
> if "debian/hivex/usr/bin/hivexsh" were not uselessly linked against it
> (they use none of its symbols).

Does the attached patch fix the issue for you?

Can you also check that configure still finds readline:

  checking for main in -lreadline... yes

and that it is still used by hivexsh.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/
-------------- next part --------------
>From 7614b64ca6c091d487a1b9c47462bd30be0f5445 Mon Sep 17 00:00:00 2001
From: TJ <linux at tjworld.net>
Date: Sat, 3 Apr 2010 10:50:48 +0100
Subject: [PATCH] Remove explicit dependency on ncurses.

---
 configure.ac |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index 8f19a2f..dda6892 100644
--- a/configure.ac
+++ b/configure.ac
@@ -143,7 +143,7 @@ AC_ARG_WITH([readline],
 LIBREADLINE=
 AS_IF([test "x$with_readline" != xno],
     [AC_CHECK_LIB([readline], [main],
-        [AC_SUBST([LIBREADLINE], ["-lreadline -lncurses"])
+        [AC_SUBST([LIBREADLINE], ["-lreadline"])
          AC_DEFINE([HAVE_LIBREADLINE], [1],
                    [Define if you have libreadline])
         ],
@@ -151,7 +151,7 @@ AS_IF([test "x$with_readline" != xno],
          AC_MSG_FAILURE(
              [--with-readline was given, but test for readline failed])
          fi
-        ], -lncurses)])
+        ])])
 
 dnl For i18n.
 AM_GNU_GETTEXT([external])
-- 
1.6.6.1