[Libguestfs] hivex: hivexsh dependency on libncurses?

[Richard W.M. Jones]

On Sat, Apr 03, 2010 at 11:47:47AM +0100, TJ wrote:
> On Sat, 2010-04-03 at 10:51 +0100, Richard W.M. Jones wrote:
> > On Sat, Apr 03, 2010 at 10:22:29AM +0100, TJ wrote:
> > > Hopefully this is my last issue raised as a result of the Debian
> > > packaging effort!
> > > 
> > > I see a warning from debhelper which suggests the linked library
> > > "libncurses" may actually be no longer required by "hivexsh". Is this
> > > so, or is it in preparation for some future use of the library?
> > > 
> > > dpkg-shlibdeps: warning: dependency on libncurses.so.5 could be avoided
> > > if "debian/hivex/usr/bin/hivexsh" were not uselessly linked against it
> > > (they use none of its symbols).
> > 
> > Does the attached patch fix the issue for you?
> 
> Yes
> 
> > Can you also check that configure still finds readline:
> > 
> >   checking for main in -lreadline... yes
> 
> Yes
> 
> > and that it is still used by hivexsh.
> 
> Yes.

OK, thanks for checking this.  I'll push the patch upstream when I get
round to fixing the git repo.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming blog: http://rwmj.wordpress.com
Fedora now supports 80 OCaml packages (the OPEN alternative to F#)
http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora