[Libguestfs] [PATCH] Fix virt-v2v exit codes

[Richard W.M. Jones]

On Mon, Apr 26, 2010 at 01:58:01PM +0100, Matthew Booth wrote:
> On 26/04/10 13:38, Richard W.M. Jones wrote:
> > On Mon, Apr 26, 2010 at 12:04:23PM +0100, Matthew Booth wrote:
> >>          $g = undef;
> >> +
> >> +        $? ||= $retval;
> > 
> > I'm a bit confused by this though.  AFAICT the Guestfs::DESTROY
> > function shouldn't change $?.
> 
> Actually I had no specific evidence that it did, I was just trying to
> cover bases. Do you think this is unnecessary?

It doesn't really matter, I was just pointing out that it won't set $?
right now.

Closing the handle does kill of the qemu subprocess, and so in theory
it could set $? to give us the status from the subprocess, although
that's unlikely to ever happen (no one cares about the status of qemu
and there's no way to get it from the current C API).

Add a comment?

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/