[Libguestfs] [PATCH] Ignore launch() error in virt-rescue

Matthew Booth mbooth at redhat.com
Thu Aug 26 14:08:20 UTC 2010


launch() expects guestfsd to start, which it never does in virt-rescue, so it
always returns an error about the appliance shutting down unexpectedly.
---
 tools/virt-rescue |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/tools/virt-rescue b/tools/virt-rescue
index 1f292f6..c84fb7f 100755
--- a/tools/virt-rescue
+++ b/tools/virt-rescue
@@ -19,6 +19,7 @@
 use warnings;
 use strict;
 
+use Errno;
 use Sys::Guestfs;
 use Sys::Guestfs::Lib qw(open_guest);
 use Pod::Usage;
@@ -214,7 +215,11 @@ $g->set_append ($str);
 
 # Run the appliance.  This won't return until the user quite the
 # appliance.
-$g->launch ();
+eval { $g->launch (); };
+
+# launch() expects guestfsd to start. However, virt-rescue doesn't run guestfsd,
+# so this will always fail with ECHILD when the appliance exits unexpectedly.
+die ($@) unless ($!{ECHILD});
 
 exit 0;
 
-- 
1.7.2.2




More information about the Libguestfs mailing list