[Libguestfs] [PATCH 2/3] Call sync after guestfsd exits

Matthew Booth mbooth at redhat.com
Tue Aug 17 12:29:05 UTC 2010


On 17/08/10 12:49, Richard W.M. Jones wrote:
> On Tue, Aug 03, 2010 at 05:20:12PM +0100, Matthew Booth wrote:
>>   sync
>>   sleep 1
>>   sync
>
> Definitely can't have a sleep here.  What's wrong with a single
> 'sync'?  It is documented that it doesn't return until all outstanding
> writes have been committed to disk.

I was actually just keeping the code that was already there. I did think 
it was a bit odd.

I can remove this.

Matt
-- 
Matthew Booth, RHCA, RHCSS
Red Hat Engineering, Virtualisation Team

GPG ID:  D33C3490
GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490




More information about the Libguestfs mailing list