[Libguestfs] [PATCH 4/9] Converter: Remove disk driver elements other than 'qemu'

[Richard W.M. Jones]

On Fri, Feb 12, 2010 at 09:39:17AM +0000, Matthew Booth wrote:
> QEMU only currently supports the qemu storage driver in libvirt. Remove any
> other driver element.
> ---
>  lib/Sys/VirtV2V/Converter.pm |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/lib/Sys/VirtV2V/Converter.pm b/lib/Sys/VirtV2V/Converter.pm
> index 4b11efd..edc6589 100644
> --- a/lib/Sys/VirtV2V/Converter.pm
> +++ b/lib/Sys/VirtV2V/Converter.pm
> @@ -436,6 +436,13 @@ sub _unconfigure_hvs
>          $emulator->getParent()->removeChild($emulator);
>      }
>  
> +    # Remove any disk driver element other than 'qemu'
> +    foreach my $driver
> +        ($dom->findnodes('/domain/devices/disk/driver[@name != \'qemu\']'))
> +    {
> +        $driver->getParentNode()->removeChild($driver);
> +    }
> +
>      _unconfigure_xen_metadata($dom, $default_dom);
>  }
>  
> -- 
> 1.6.6

Not sure I understand this.  Looking at:

http://libvirt.org/formatdomain.html#elementsDisks

won't this change end up deleting important disks from the guest?

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
New in Fedora 11: Fedora Windows cross-compiler. Compile Windows
programs, test, and build Windows installers. Over 70 libraries supprt'd
http://fedoraproject.org/wiki/MinGW http://www.annexia.org/fedora_mingw