[Libguestfs] [PATCH 2/2] GuestOS: Always call aug_save() after aug_set()

Matthew Booth mbooth at redhat.com
Fri Feb 19 16:42:57 UTC 2010


We call aug_load() in various places. This call explicitly throws away any
unsaved changes in the tree. For safety, we should always call aug_save() after
making changes to the tree. This change adds 2 missing calls.
---
 lib/Sys/VirtV2V/GuestOS/RedHat.pm |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/lib/Sys/VirtV2V/GuestOS/RedHat.pm b/lib/Sys/VirtV2V/GuestOS/RedHat.pm
index 6adf8b8..5b7a95a 100644
--- a/lib/Sys/VirtV2V/GuestOS/RedHat.pm
+++ b/lib/Sys/VirtV2V/GuestOS/RedHat.pm
@@ -266,6 +266,7 @@ sub enable_kernel_module
         $g->aug_set("/files/".$self->{modules}."/alias[last()+1]", $device);
         $g->aug_set("/files/".$self->{modules}."/alias[last()]/modulename",
                     $module)
+        $g->aug_save();
     };
 
     # Propagate augeas errors
@@ -1113,6 +1114,7 @@ sub prepare_bootable
                 last;
             }
         }
+        $g->aug_save();
     };
 
     # Propagate augeas failure
-- 
1.6.6




More information about the Libguestfs mailing list