[Libguestfs] [PATCH 2/4] MetadataReader: Allow different libvirt connections for input and output

[Matthew Booth]

On 29/01/10 19:27, Richard W.M. Jones wrote:
> On Fri, Jan 29, 2010 at 06:05:08PM +0000, Matthew Booth wrote:
>> Command line option changes:
>> --config ->  -c
>> -c ->  -ic
>>
>> New option -oc specifies output connection.
>
>
>>   GetOptions ("help|?"      =>  \$help,
>>               "version"     =>  \$version,
>> -            "connect|c=s" =>  \$uri,
>> -            "input|i=s"   =>  \$input,
>> -            "config|s=s"  =>  \$config_file
>> +            "i=s"         =>  \$input_method,
>> +            "ic=s"        =>  \$input_uri,
>> +            "oc=s"        =>  \$output_uri,
>> +            "c=s"         =>  \$config_file
>
> This one I'm very dubious about.
>
> I think you should retain -c/--connect because that's sort of the
> standard for specifying the libvirt URI to virsh and virt-* tools.
> However obviously you need two URIs, so I think -c/--connect should
> give an error message, stating that the option has been replaced by
> -ic and -oc and directing the user to some more documentation about
> that.
>
> Now you also want to reuse -c to specify the config file, but I think
> you should use -f for that, which a lot of programs use.

Agreed. I'll update that.

Matt