[Libguestfs] [PATCH 6/7] Fix logging of error messages in augeas_error

Matthew Booth mbooth at redhat.com
Tue Apr 26 16:56:40 UTC 2011


On 26/04/11 17:55, Richard W.M. Jones wrote:
> On Tue, Apr 26, 2011 at 05:03:51PM +0100, Matthew Booth wrote:
>> ---
>>   lib/Sys/VirtConvert/Util.pm |    4 ++--
>>   1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/lib/Sys/VirtConvert/Util.pm b/lib/Sys/VirtConvert/Util.pm
>> index 94211a5..b74d750 100644
>> --- a/lib/Sys/VirtConvert/Util.pm
>> +++ b/lib/Sys/VirtConvert/Util.pm
>> @@ -121,8 +121,8 @@ sub augeas_error
>>
>>       chomp($msg);
>>
>> -    v2vdie $msg if length($msg)>  0;
>> -    v2vdie $err;
>> +    v2vdie($msg) if length($msg)>  0;
>> +    v2vdie($err);
>>   }
>
> ACK.
>
> Bit surprised the without-parens version doesn't work though ...

Me too. The output it produces, though, suggests it's trying to do 
$err->v2vdie().

Matt
-- 
Matthew Booth, RHCA, RHCSS
Red Hat Engineering, Virtualisation Team

GPG ID:  D33C3490
GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490




More information about the Libguestfs mailing list