[Libguestfs] hivex: some issues (key encoding, ...) and suggested fixes

[Török Edwin]

On 2011-02-28 16:33, Matthew Booth wrote:
> On 26/02/11 18:56, Török Edwin wrote:
>> [...]
>> 4. hivexml output is not a well-formed XML
>>
>> See problem #1 and #2, if value_string and node_name are fixed to not
>> dump the binary garbage and just return UTF8 then I think hivexml's
>> output would pass xmllint.
> 
> As it happens, I opened a BZ on this just the other day. I think there's
> an additional element here: it seems that sometimes a registry key
> genuinely contains non-text data. An example is
> HKLM/SOFTWARE/Microsoft/MSDTC/Security/XAKey, which I'm guessing is a
> cryptographic key. This would require a CDATA section. However, it's not
> clear to me how the tool can reliably infer that a value is binary data
> without specific knowledge of the schema.

If it contains control characters, then it should probably be escaped
before output to XML.

Best regards,
--Edwin