[Libguestfs] febootstrap: what am I doing wrong?

[Richard W.M. Jones]

On Tue, May 31, 2011 at 12:14:11AM +0200, Hilko Bengen wrote:
> * Hilko Bengen:
> 
> > * Richard W.M. Jones:
> >
> >> Which version of febootstrap is this? If you're not using febootstrap
> >> from git could you try that version?
> >
> > I was using version 3.5 from the tarball. The last commit on the master
> > branch is tagged as 3.5.
> 
> After adding a line containing "/lib/modules" to hostfiles solved the
> immediate problem for me -- febootstrap-supermin-helper finished its
> run.
> 
> The attached patch makes sure that febootstrap-supermin-helper always
> creates this directory.
> 
> Cheers,
> -Hilko

> diff --git a/helper/appliance.c b/helper/appliance.c
> index 85efd75..50d1d78 100644
> --- a/helper/appliance.c
> +++ b/helper/appliance.c
> @@ -77,6 +77,7 @@ create_appliance (const char *hostcpu,
>  
>    iterate_inputs (inputs, nr_inputs, writer);
>  
> +  writer->wr_file ("/lib/modules");
>    /* Kernel modules (3). */
>    add_kernel_modules (whitelist, modpath, writer);
>  

I guess that either /lib/modules is missing from the Debian packages
altogether, or one of the packages that we exclude contains this
directory.  No matter though, because it seems completely safe to add
this patch.

Thanks,

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming blog: http://rwmj.wordpress.com
Fedora now supports 80 OCaml packages (the OPEN alternative to F#)
http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora