[Libguestfs] [PATCH 2/3] hivex: check for presence of OCaml native compiler
Richard W.M. Jones
rjones at redhat.com
Thu May 12 08:05:49 UTC 2011
On Thu, May 12, 2011 at 09:00:25AM +0100, Richard W.M. Jones wrote:
> On Thu, May 12, 2011 at 12:04:19AM +0200, bengen at hilluzination.de wrote:
> > From: Hilko Bengen <bengen at hilluzination.de>
> >
> > Only compile bytecode otherwise, avoiding ocamlfind's helpful error
> > message "ocamlfind: Not supported in your configuration: ocamlopt"
> >
> > (Successfully tested on Debian/unstable on alpha)
>
> The problem with this patch is that OCaml users won't get the native
> version. This is vital on platforms that do have the native compiler.
>
> The fix here must be to detect if the native version is available and
> compile it conditionally. ocaml-autoconf macros are already doing the
> detection, see:
Ignore that, I wasn't reading the end of the patch.
ACK. I'll apply it upstream later today.
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine. Supports Linux and Windows.
http://et.redhat.com/~rjones/virt-df/
More information about the Libguestfs
mailing list