[Libguestfs] [PATCH 3/5] debian: Fix Debian package handler when --use-installed not given.

Richard W.M. Jones rjones at redhat.com
Tue Oct 18 13:21:01 UTC 2011


From: "Richard W.M. Jones" <rjones at redhat.com>

If there is no --use-installed option, then it didn't download all the
packages (only the ones not installed).  But this failed later when it
tried to unpack the packages that hadn't been downloaded.

Thus download all the packages if !use_installed.
---
 src/febootstrap_debian.ml |   10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/src/febootstrap_debian.ml b/src/febootstrap_debian.ml
index 85c9b7e..0169756 100644
--- a/src/febootstrap_debian.ml
+++ b/src/febootstrap_debian.ml
@@ -62,9 +62,13 @@ let rec debian_resolve_dependencies_and_download names =
         not (List.exists (fun re -> Str.string_match re name 0) excludes)
     ) pkgs in
 
-  let present_pkgs, download_pkgs = List.partition (
-    fun pkg -> List.exists ((=) pkg) (get_installed_pkgs ())
-  ) pkgs in
+  let present_pkgs, download_pkgs =
+    if not use_installed then
+      [], pkgs
+    else
+      List.partition (
+	fun pkg -> List.exists ((=) pkg) (get_installed_pkgs ())
+      ) pkgs in
 
   debug "wanted packages (present / download): %s / %s\n"
     (String.concat " " present_pkgs)
-- 
1.7.6




More information about the Libguestfs mailing list