[Libguestfs] [PATCH 01/10] Revert "Revert "generator: Add CamelName flag""

Matthew Booth mbooth at redhat.com
Fri Jan 20 12:30:05 UTC 2012


On 01/20/2012 12:15 PM, Richard W.M. Jones wrote:
> On Fri, Jan 20, 2012 at 11:07:44AM +0000, Matthew Booth wrote:
>> This reverts commit 3f6ca541c7b24d4c86688a509582cb41a7e0078c.
>>
>> The original commit was reverted prematurely.
>
> No, the original commit was reverted for good reason.

I didn't say there was no reason, I said it was premature. This is born 
out in the very next patch un-reverting it :)

> Please change the commit message so it reflects what the patch does.

It's technically correct. It reverts a revert ;)

But if you insist... (Is your chain yanked sufficiently hard, yet?)

> Also the comment should be changed to note that 'CamelName' only has
> any effect in the GObject bindings.

Ok, I'll make this change locally. I won't bother reposting the whole 
series just for this, though.

Matt
-- 
Matthew Booth, RHCA, RHCSS
Red Hat Engineering, Virtualisation Team

GPG ID:  D33C3490
GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490




More information about the Libguestfs mailing list