[Libguestfs] [PATCH V3 2/2] xfs_info: resolve device when doing xfs_info on a device

Richard W.M. Jones rjones at redhat.com
Tue Jul 24 08:32:40 UTC 2012


On Mon, Jul 23, 2012 at 05:51:32PM +0800, Wanlong Gao wrote:
> -    style = RStruct ("info", "xfsinfo"), [Pathname "path"], [];
> +    style = RStruct ("info", "xfsinfo"), [String "pathordevice"], [];

Actually NACK to this.  I don't understand why you don't
use Dev_or_Path here.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://et.redhat.com/~rjones/virt-top




More information about the Libguestfs mailing list