[Libguestfs] [PATCH V1] NEW API:ext:mke2fs

[Richard W.M. Jones]

On Mon, Sep 03, 2012 at 11:44:15AM +0800, Wanlong Gao wrote:
> On 08/31/2012 06:00 PM, Wanlong Gao wrote:
> > New api mke2fs for full configuration of filesystem.
> > 
> > Signed-off-by: Wanlong Gao <gaowanlong at cn.fujitsu.com>
> > ---
> >  daemon/ext2.c                  | 452 +++++++++++++++++++++++++++++++++++++++++
> >  generator/generator_actions.ml |  18 ++
> >  gobject/Makefile.inc           |   6 +-
> >  src/MAX_PROC_NR                |   2 +-
> >  4 files changed, 475 insertions(+), 3 deletions(-)
> 
> Hi Rich,
> 
> I got the following error when compiling with this patch, it seems that the
> long typed optargs_bitmask can't accept more than 31 optional arguments, it's
> odd ?  This mke2fs api has about 43 optional arguments, so 64bit typed optargs_bitmask
> is enough, but why does long type limit the arguments to 31?

No, this is a bug.

The limit should be *63* optional arguments.  (Actually we could do
more than this in future, but we'd have to change the XDR protocol to
support that).

> ./com/redhat/et/libguestfs/GuestFS.java:14731: error: integer number too large: 2147483648
>       _optargs_bitmask |= 2147483648;

This is a bug in the generator:  I'll post a fix soon.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://et.redhat.com/~rjones/virt-top