[Libguestfs] [PATCH] handle --use-installed in zypp driver

Richard W.M. Jones rjones at redhat.com
Mon Apr 29 15:25:20 UTC 2013


On Mon, Apr 29, 2013 at 03:22:06PM +0200, Olaf Hering wrote:
> On Thu, Apr 11, Olaf Hering wrote:
> 
> > +	-m \"stream/install-summary/to-install/solvable[%@type='package']\" \
> > +	-c \"string(%@name)\" -n
> 
> This is supposed to be "[@type='package']" and "string(@name)". Some of
> the ocaml printf docs made me believe that "%@" is the way to print a
> single "@".
> Now I see this part was changed to "%%@", which puts an extra % into the
> output string.
> 
> Is the @ sign a special char in ocaml printf? 

@ on its own is not special.

%@ (as in the original patch) broke older OCaml.  In newer OCaml it is
silently converted to @ which is probably a bug in OCaml.  The
breakage in old OCaml was why I replaced it with %%@.

I have pushed this:

https://github.com/libguestfs/supermin/commit/3329297abe2e7e055337583b2221fcade85f9f6b

Thanks,

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org




More information about the Libguestfs mailing list