[Libguestfs] missing lvm.conf is fatal

[Richard W.M. Jones]

On Tue, Apr 02, 2013 at 01:57:25PM +0200, Olaf Hering wrote:
> 
> I have a report for 1.20.4 about this error. There is no /etc/lvm/lvm.conf in
> the guest, which is handled as fatal error. Creating an emtpy file with that
> name is a workaround for the time being.

Is this caused by either of d8f14591d10df847fad2e24f2f430b2543020912
or 9fd41abd40c3ffc10985e862dc34c868360a1b22?

Do they not have lvm.conf at all, or is it located in /etc/lvm.conf?

> $ virt-resize --expand /dev/sda2 in.img out.img
> Examining in.img ...
> Fatal error: exception Guestfs.Error("lvm_set_filter: open: /tmp/lvmiUFSBa/lvm/lvm.conf: No such file or directory")
>
> Maybe the callers of lvm_set_filter or lvm_set_filter itself can be
> more forgiving.

In this case, lvm_set_filter really needs to edit lvm.conf.  It could
be more forgiving by creating a new file with a single 'filter' rule
in it however.

Also lvm-filter is a fairly obscure feature.  With a bit of thought we
could probably remove its use from the one remaining place in the
libguestfs code (virt-resize).

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming blog: http://rwmj.wordpress.com
Fedora now supports 80 OCaml packages (the OPEN alternative to F#)