[Libguestfs] missing mount cmd confuses guestfish

[Richard W.M. Jones]

On Thu, Aug 22, 2013 at 07:33:09PM +0100, Richard W.M. Jones wrote:
> On Thu, Aug 22, 2013 at 02:40:27PM +0200, Olaf Hering wrote:
> > On Sun, Aug 18, Olaf Hering wrote:
> > 
> > > 
> > > I think calling "sh" before "mount" should not confuse guestfish like
> > > that:
> > > 
> > > # guestfish (1.20.4 on sles11sp3)
> > 
> > Doing the same, by accident, with 1.22.5 causes a crash:
> > 
> > 
> > # guestfish -r -v --network
> > ><fs> add-drive /work/kvm/images/opensuse12.3/disk0.raw
> > ><fs> launch
> > 
> > ><fs> sh "ip a"
> > guestfsd: main_loop: new request, len 0x30
> > guestfsd: error: do_command: you must call 'mount' first to mount the root filesystem
> > *** glibc detected *** guestfsd: free(): invalid pointer: 0x00007fffd8425ba0 ***
> > libguestfs: error: sh: do_command: you must call 'mount' first to mount the root filesystem
> > ><fs> mount /de======= Backtrace: =========
> > /lib64/libc.so.6(+0x733b6)[0x7f4994ae83b6]
> > /lib64/libc.so.6(cfree+0x6c)[0x7f4994aed2dc]
> > guestfsd[0x409e6f]
> > guestfsd[0x40a01b]
> > guestfsd[0x43e9a1]
> > guestfsd[0x422bd7]
> > guestfsd[0x41606c]
> > /lib64/libc.so.6(__libc_start_main+0xfd)[0x7f4994a93bfd]
> > uestfsd[0x405189]
> 
> Yup, that's a bug :-(
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1000121

Seems to just be a missing initializer:

https://github.com/libguestfs/libguestfs/commit/fc2947b1125aa34b5f04efd2d39cb82b2ebba586

I'll look for similar cases.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW