[Libguestfs] [PATCH 28/46] virt-list-filesystems: Fix to use $g->canonical_device_name instead of homebrew function.

Richard W.M. Jones rjones at redhat.com
Sat Aug 24 12:37:04 UTC 2013


From: "Richard W.M. Jones" <rjones at redhat.com>

The homebrew function didn't recognize /dev/ubd* device names, and in
any case using the API function is shorter and clearer.

(cherry picked from commit 42754046269806a6b6385fee0b72115c73461221)
(cherry picked from commit b312c245d3efb458609f9064a75a2f02a5181af4)
---
 tools/virt-list-filesystems | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

diff --git a/tools/virt-list-filesystems b/tools/virt-list-filesystems
index 1b58d63..9dcba24 100755
--- a/tools/virt-list-filesystems
+++ b/tools/virt-list-filesystems
@@ -167,7 +167,7 @@ foreach $dev (sort keys %fses) {
     $fstype = $fses{$dev};
 
     if ($all || ($fstype ne "swap" && $fstype ne "unknown")) {
-        print canonicalize($dev);
+        print $g->canonical_device_name ($dev);
         if ($long) {
             print " $fstype";
         }
@@ -175,18 +175,6 @@ foreach $dev (sort keys %fses) {
     }
 }
 
-# The reverse of device name translation, see
-# BLOCK DEVICE NAMING in guestfs(3).
-sub canonicalize
-{
-    local $_ = shift;
-
-    if (m{^/dev/[hv]d([a-z]\d)$}) {
-        return "/dev/sd$1";
-    }
-    $_;
-}
-
 =head1 SHELL QUOTING
 
 Libvirt guest names can contain arbitrary characters, some of which
-- 
1.8.3.1




More information about the Libguestfs mailing list