[Libguestfs] [PATCH 1/2] proto: Remove error message which hides earlier error.

Richard W.M. Jones rjones at redhat.com
Tue Dec 10 08:58:40 UTC 2013


From: "Richard W.M. Jones" <rjones at redhat.com>

When chunked encoding fails, the following error is added to
the handle:

  [filename]: error in chunked encoding

However all paths returning -1 from receive_file_data already set a
more specific error, which this error hides.
---
 src/proto.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/proto.c b/src/proto.c
index 6dc4c16..1117368 100644
--- a/src/proto.c
+++ b/src/proto.c
@@ -781,7 +781,6 @@ guestfs___recv_file (guestfs_h *g, const char *filename)
   }
 
   if (r == -1) {
-    error (g, _("%s: error in chunked encoding"), filename);
     close (fd);
     return -1;
   }
-- 
1.8.3.1




More information about the Libguestfs mailing list