[Libguestfs] [PATCH] lib: fix newline in error output
Pino Toscano
ptoscano at redhat.com
Tue Dec 10 09:30:30 UTC 2013
On Monday 09 December 2013 19:26:47 Richard W.M. Jones wrote:
> On Mon, Dec 09, 2013 at 08:13:19PM +0100, Pino Toscano wrote:
> > See also RHBZ#923355.
> > ---
> >
> > src/actions-support.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/actions-support.c b/src/actions-support.c
> > index d0e3e67..00d8cdc 100644
> > --- a/src/actions-support.c
> > +++ b/src/actions-support.c
> > @@ -68,7 +68,7 @@ int
> >
> > guestfs___check_appliance_up (guestfs_h *g, const char *caller)
> > {
> >
> > if (g->state == CONFIG || g->state == LAUNCHING) {
> >
> > - error (g, "%s: call launch before using this function\\n(in
> > guestfish, don't forget to use the 'run' command)", + error (g,
> > "%s: call launch before using this function\n(in guestfish, don't
> > forget to use the 'run' command)",>
> > caller);
> >
> > return -1;
> >
> > }
>
> ACK.
>
> That's a stupid mistake :-(
>
> I believe this actually fixes RHBZ#923355? So probably best to put
> that in the subject line of the bug before you push it, and also to
> close the bug.
The bug seemed a bit more generic, not just about this specific
occurrence. That's why I left a comment in it, and just mentioned it in
the commit message of this patch without the closing syntax.
I just changed the commit message and pushed it, and the bug closing
will come shortly.
Thanks,
--
Pino Toscano
More information about the Libguestfs
mailing list