[Libguestfs] [PATCH] drives: add CD-ROM disk images as read-only drives (RHBZ#563450).

[Richard W.M. Jones]

On Mon, Dec 16, 2013 at 01:42:51PM +0100, Pino Toscano wrote:
> On Saturday 14 December 2013 22:50:28 Richard W.M. Jones wrote:
> > Earlier in the test, you'll probably need to add this:
> > 
> >   if [ ! -s ../guests/fedora.img -o ! -s ../guests/debian.img ]; then
> >       echo "$0: test skipped because there is no fedora.img or
> > debian.img" exit 77
> >   fi
> 
> It seems there are few more tests that don't check for the existence of 
> test guests and isos:
>   align/test-virt-alignment-scan.sh
[...]

The tests/guests stuff is a bit of a mess:

(1) The windows.img can be created zero-sized if there's no NTFS
support.  The comment in tests/guests/guest-aux/make-windows-img.sh is
quite blasé saying "Nothing actually uses windows.img in the standard
build" which is not true at all!

(2) Lack of MD support would prevent us from creating the fedora-md*
guest.  I can't remember what exactly happens in this case.

(3) Lack of btrfs support would prevent us from creating the
fedora-btrfs.img guest.  It's quite common that btrfs is broken or
missing altogether, especially on less common distros.

(4) Lack of LVM support [yes, this can happen] can prevent us from
creating any Linux guest.

(5) Various files are derived from the test images, eg:

  builder/test-index
  builder/*.xz
  builder/*.qcow2
  builder/*.qcow2.xz

but these sometimes don't omit guests which we couldn't create.

(Note that tests/guests/guests-all-good.xml gets this right)

The builder/* ones should be created in the tests/guests directory,
and the virt-builder tests should use them out of that directory.

(6) UML doesn't support qcow2.

And of course ...

(7) Phony guests are nice for simple tests, but don't really test
inspection.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW