[Libguestfs] [PATCH] Re-add regression tests for rh#563450

Richard W.M. Jones rjones at redhat.com
Thu Dec 19 18:36:46 UTC 2013


On Thu, Dec 19, 2013 at 04:30:57PM +0100, Pino Toscano wrote:
> Added in 2392fae6803b9de4a4761509007c160339d57f50 and removed in
> be025369ad622867ecf08d5c9170e8e59d2d6294; now they should work with any
> backend, as the device names are normalised and not change the guestfish
> output depending on the used backend.
> 
> Thanks Richard for the hints.

ACK.

> +../../fish/guestfish --ro > test.out <<EOF

It could also be done as:

  ../../fish/guestfish --ro | sed ... > test.out

which would be one sed invocation.  However I think that would hide
any errors / segfaults in guestfish, so the way you've got it now
seems more robust.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming blog: http://rwmj.wordpress.com
Fedora now supports 80 OCaml packages (the OPEN alternative to F#)




More information about the Libguestfs mailing list