[Libguestfs] [PATCH 2/4] out-of-tree build: fix test-tool

[Richard W.M. Jones]

On Mon, Feb 18, 2013 at 10:43:41PM +0100, Hilko Bengen wrote:
> (Not entirely sure whether using Gnulib to replace standard functions
> is a good idea at all.)
> 
> link with libgnu:
>   CCLD   libguestfs-test-tool
> libguestfs_test_tool-test-tool.o: In function `main':
> /home/bengen/src/deb/pkg-libvirt/libguestfs/debian/build-default/test-tool/../../../test-tool/test-tool.c:103: undefined reference to `rpl_getopt_long'
> /home/bengen/src/deb/pkg-libvirt/libguestfs/debian/build-default/test-tool/../../../test-tool/test-tool.c:113: undefined reference to `rpl_optarg'
> /home/bengen/src/deb/pkg-libvirt/libguestfs/debian/build-default/test-tool/../../../test-tool/test-tool.c:125: undefined reference to `rpl_optarg'
> /home/bengen/src/deb/pkg-libvirt/libguestfs/debian/build-default/test-tool/../../../test-tool/test-tool.c:126: undefined reference to `rpl_optarg'
> /home/bengen/src/deb/pkg-libvirt/libguestfs/debian/build-default/test-tool/../../../test-tool/test-tool.c:109: undefined reference to `rpl_optarg'
> libguestfs_test_tool-test-tool.o: In function `set_qemu':
> /home/bengen/src/deb/pkg-libvirt/libguestfs/debian/build-default/test-tool/../../../test-tool/test-tool.c:382: undefined reference to `rpl_perror'
> /home/bengen/src/deb/pkg-libvirt/libguestfs/debian/build-default/test-tool/../../../test-tool/test-tool.c:366: undefined reference to `rpl_perror'
> libguestfs_test_tool-test-tool.o: In function `make_files':
> /home/bengen/src/deb/pkg-libvirt/libguestfs/debian/build-default/test-tool/../../../test-tool/test-tool.c:416: undefined reference to `rpl_perror'
> /home/bengen/src/deb/pkg-libvirt/libguestfs/debian/build-default/test-tool/../../../test-tool/test-tool.c:428: undefined reference to `rpl_perror'
> ---
>  test-tool/Makefile.am |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/test-tool/Makefile.am b/test-tool/Makefile.am
> index 200f2cb..bb2e03c 100644
> --- a/test-tool/Makefile.am
> +++ b/test-tool/Makefile.am
> @@ -37,7 +37,8 @@ libguestfs_test_tool_CFLAGS = \
>  	$(GPROF_CFLAGS) $(GCOV_CFLAGS)
>  
>  libguestfs_test_tool_LDADD = \
> -	$(top_builddir)/src/libguestfs.la
> +	$(top_builddir)/src/libguestfs.la \
> +	$(top_builddir)/gnulib/lib/libgnu.la
>  
>  libguestfs-test-tool.1 $(top_builddir)/html/libguestfs-test-tool.1.html: stamp-libguestfs-test-tool.pod
>  
> -- 
> 1.7.10.4

Weird ... but ... ACK.  I wonder why we don't see this error on
Fedora?  In any case I can't see any problem with linking
libguestfs-test-tool to gnulib.  In fact I don't know why we weren't
doing that already.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org