[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH stable-1.24] Fix fstab block device resolution for FreeBSD



Hello Richard,

I think my patch is sufficient. I don't thing you need this patch at 
all. The regular expression /dev/(ada{0,1}|vtbd)
will match both: /dev/ada and  /dev/ad. This is why I use "{0,1}" 
(=zero or one occurrence of the character a)

Nikos

On Tue 05 Nov 2013 01:42:44 PM EET, Richard W.M. Jones wrote:
> On Tue, Nov 05, 2013 at 12:15:47PM +0200, Nikos Skalkotos wrote:
>> The device name prefix for IDE hard drives used to be `ad' but now
>> is `ada' (http://www.freebsd.org/doc/handbook/disks-naming.html).
>> For virtio hard drives it is `vtbd'.
>>
>> Under an MBR partition table a slice will be used, so the name of
>> the first partitions will be either `ada0s1a' or `vtbd0s1a'. Under a
>> GPT partition table, where no slice is needed, the name of the first
>> partition will be either `ada0p1' or `vtbd0p1'.
>>
>> Signed-off-by: Nikos Skalkotos <skalkoto grnet gr>
>
> I've applied this.
>
> I also applied the attached patch, which readds support for the old
> format, on the assumption that old FreeBSD guests will still exist for
> some time to come.  Hope this is OK.
>
> Thanks,
>
> Rich.
>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]