[Libguestfs] [PATCHp2v v2] virt-p2v-server: Die with the correct error message.

Richard W.M. Jones rjones at redhat.com
Wed Oct 2 12:28:39 UTC 2013


From: "Richard W.M. Jones" <rjones at redhat.com>

Although the code is technically correct (because the successful call
to $g->close won't overwrite $@ and because guestfs_close can never
fail) it's still confusing to assign $err = $@ and then not use $err.

Die with $err.  It's possible something added here could overwrite $@
at some later time.
---
 p2v/server/virt-p2v-server.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/p2v/server/virt-p2v-server.pl b/p2v/server/virt-p2v-server.pl
index c15efb2..0121ab2 100755
--- a/p2v/server/virt-p2v-server.pl
+++ b/p2v/server/virt-p2v-server.pl
@@ -405,7 +405,7 @@ sub convert
         my $err = $@;
         $g->close() if defined($g);
 
-        die($@);
+        die($err);
     }
 
     p2v_return_ok();
-- 
1.8.3.1




More information about the Libguestfs mailing list