[Libguestfs] augeas changes in stable branches

Olaf Hering olaf at aepfle.de
Fri Oct 18 13:55:23 UTC 2013


On Fri, Oct 18, Richard W.M. Jones wrote:

> On Fri, Oct 18, 2013 at 11:15:54AM +0200, Olaf Hering wrote:
> > 
> > commit f59b87f7f18d9df89ff9940a317ff1fb452cbd28 breaks compile with older
> > augeas (0.7.4). AFAIK there is no requirement for augeas 1.0 until 1.24.
> > 
> >  augeas.c: In function 'do_aug_init':
> >  augeas.c:102:38: error: 'AUG_NO_ERR_CLOSE' undeclared (first use in this function)
> 
> That's a mistake on the stable-1.22 branch.  Does simply reverting
> that patch fix the problem?  If so I will push a revert commit.

AUG_NO_ERR_CLOSE is not a define but an enum. So
f59b87f7f18d9df89ff9940a317ff1fb452cbd28 is correct by itself, but
3d132f29204e8c5c77f08841b5288dfe3013f4f0 will cause the error by using
an undeclared value.

I suggest to revert both commits.

Olaf




More information about the Libguestfs mailing list