[Libguestfs] [PATCH] virt-v2v: Convert RedHat.pm to Linux.pm - for SUSE support

Mike Latimer mlatimer at suse.com
Tue Oct 8 15:25:26 UTC 2013


On Tuesday, October 08, 2013 10:05:17 AM Matthew Booth wrote:
> Feel free to remove ^$path. However, for robustness I ditch the leading
> ^ from your replacement. The difference will be down to a different
> version of file included in the libguestfs appliance on SUSE.

Ok.

> _install_config should already install all dependencies in a single
> transaction for exactly this reason. If it doesn't, we should fix that.
> I take it zypper just does the right thing?

When I call zypper, I'm only passing in the 'kernel' installation request. 
zypper resolves any dependencies (such as kernel-base), and installs them as 
necessary.

In the case of _install_config, my original changes added both kernel-base and 
kernel to a single list, and installed them together to avoid dependency 
issues. Changing to the 'app dep' approach with kernel-base does allow the 
dependent kernel-base to be installed first, so the next kernel installation 
will work. However, it installs the kernel-base package using 'rpm -U' instead 
of 'rpm -i'. I decided it would be safer to just construct a new list, and 
install them both using the same method.

> I'm not convinced. Either IDE devices will be presented as scsi devices
> (default libata), or they won't (non-libata, or udev rewriting to
> maintain the legacy behaviour). I'd be surprised to find a configuration
> where some IDE devices become SCSI devices, but others don't.

Ok. I won't worry about this possibility then.

Thanks,
Mike




More information about the Libguestfs mailing list