[Libguestfs] [PATCH] btrfs: Fix improper memmove usage in do_btrfs_subvolume_list

John Eckersberg jeckersb at redhat.com
Sat Oct 12 02:26:07 UTC 2013


The third parameter (number of bytes to copy) was given as an offset
relative to dest, when it should be relative to src.  This fixes some
valgrind warnings I happened across.
---
 daemon/btrfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/daemon/btrfs.c b/daemon/btrfs.c
index c3247ac..765dec6 100644
--- a/daemon/btrfs.c
+++ b/daemon/btrfs.c
@@ -473,7 +473,7 @@ do_btrfs_subvolume_list (const mountable_t *fs)
 
     #undef XSTRTOU64
 
-    memmove (line, line + ovector[6], ovector[7] + 1);
+    memmove (line, line + ovector[6], ovector[7] - ovector[6] + 1);
     this->btrfssubvolume_path = line;
   }
 
-- 
1.8.3.1




More information about the Libguestfs mailing list