[Libguestfs] [PATCH] virt-v2v: Remove iface:ide parameter (RHBZ#895898)

[Mike Latimer]

The iface:ide parameter (used in the libguestfs add_drive call) does not work
with a libvirt backend. The error usually seen is:

 'iface' parameter is not supported by the libvirt attach-method at
 /usr/share/perl5/vendor_perl/Sys/VirtConvert/GuestfsHandle.pm line 96.

This issue was previously mentioned in this thread: 
https://www.redhat.com/archives/libguestfs/2013-February/msg00057.html, and a 
workaround of 'export LIBGUESTFS_ATTACH_METHOD=appliance' was suggested. 
However, as mentioned in the bug, this parameter is likely no longer required. 
Unless there is a use-case where this setting is required, it seems like a 
good idea to remove it completely (which should work in
either libvirt or direct mode), rather than recommend the workaround.

---
 lib/Sys/VirtConvert/GuestfsHandle.pm | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/lib/Sys/VirtConvert/GuestfsHandle.pm 
b/lib/Sys/VirtConvert/GuestfsHandle.pm
index 549ba11..71f11da 100644
--- a/lib/Sys/VirtConvert/GuestfsHandle.pm
+++ b/lib/Sys/VirtConvert/GuestfsHandle.pm
@@ -73,21 +73,18 @@ sub new
     # Open a guest handle
     my $g;
     my $open = sub {
-        my $interface = "ide";
-
         $g = Sys::Guestfs->new();
         foreach my $disk (@{$disks}) {
             my ($name, $path, $format) = @$disk;

             $g->add_drive_opts($path,
                                format => $format,
-                               iface => $interface,
                                name => $name);
         }

         # Add the transfer iso if there is one
         $g->add_drive_opts($transfer,
-                           format => 'raw', iface => $interface, readonly => 
1)
+                           format => 'raw', readonly => 1)
             if defined($transfer);

         # Enable networking in the guest
-- 
1.8.1.4