[Libguestfs] [PATCH] listfs: If LDM not available, don't inhibit partition detection (RHBZ#1079182).

[Pino Toscano]

On Friday 21 March 2014 15:24:01 Richard W.M. Jones wrote:
> If a disk has type 0x42 partition (which would indicate LDM), but LDM
> is not available then try parsing the partition anyway.  It might be
> parseable as plain old NTFS.

Hasn't this been committed? It would seem fine.

> ---
>  src/listfs.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/src/listfs.c b/src/listfs.c
> index bbdb0a2..ffb0adc 100644
> --- a/src/listfs.c
> +++ b/src/listfs.c
> @@ -47,8 +47,11 @@ guestfs__list_filesystems (guestfs_h *g)
>  {
>    size_t i;
>    DECLARE_STRINGSBUF (ret);
> +
>    const char *lvm2[] = { "lvm2", NULL };
> +  int has_lvm2 = guestfs_feature_available (g, (char **) lvm2);
>    const char *ldm[] = { "ldm", NULL };
> +  int has_ldm = guestfs_feature_available (g, (char **) ldm);

Maybe it is more just matter of style, but has_lvm2 and has_ldm could be 
booleans to ease the code and the readability.

-- 
Pino Toscano