[Libguestfs] [PATCH 00/13] code refactorings for tools

Pino Toscano ptoscano at redhat.com
Thu Aug 28 13:21:03 UTC 2014


Hi,

this series does a couple of code reorganizations/refactoring in code
used by tools: the windows path handling code, and the two types of
file editing (using editor, and using perl expression).

There's still a code duplication between the two variants of file
editing, but it is just within a single source, and can be easily
solved now (planning as next step).


Pino Toscano (13):
  edit: move windows path code to common file
  fish, edit: specifies whether mount Windows as readonly
  fish, edit: move the exit-on-case-sensitive-error behaviour to
    virt-edit
  cat: use the common Windows path handling code
  fish: isolate file editing (w/ editor) code in own file
  fish: edit: improve the editor execution
  fish: edit: bring backup extension to file editing w/ editor
  fish: edit: return 1 for unchanged file
  fish: edit: bring the fast-time-edit protection
  fish: edit: add perl file editing
  edit: switch to common editing functions
  fish: edit: add verbose parameter
  customize: use the common perl file editing code

 builder/Makefile.am     |   2 +
 cat/Makefile.am         |   4 +-
 cat/cat.c               | 112 +--------------
 customize/Makefile.am   |   5 +-
 customize/perl_edit-c.c |  55 ++++++++
 customize/perl_edit.ml  |  62 +-------
 edit/Makefile.am        |   6 +-
 edit/edit.c             | 368 +++---------------------------------------------
 fish/Makefile.am        |   2 +
 fish/edit.c             | 125 +---------------
 fish/file-edit.c        | 325 ++++++++++++++++++++++++++++++++++++++++++
 fish/file-edit.h        |  47 +++++++
 fish/windows.c          | 135 ++++++++++++++++++
 fish/windows.h          |  45 ++++++
 po/POTFILES             |   3 +
 sysprep/Makefile.am     |   2 +
 v2v/Makefile.am         |   2 +
 17 files changed, 663 insertions(+), 637 deletions(-)
 create mode 100644 customize/perl_edit-c.c
 create mode 100644 fish/file-edit.c
 create mode 100644 fish/file-edit.h
 create mode 100644 fish/windows.c
 create mode 100644 fish/windows.h

-- 
1.9.3




More information about the Libguestfs mailing list