[Libguestfs] [PATCH] p2v: wait for qemu-nbd before starting conversion (RHBZ#1167774)
John Eckersberg
jeckersb at redhat.com
Mon Dec 8 14:08:13 UTC 2014
"Richard W.M. Jones" <rjones at redhat.com> writes:
> Hi John,
>
> Looks good. I've attached a slightly modified patch:
>
> - Don't need to define the WAIT_* timeout in the header file.
>
> - Call set_conversion_error in the subroutine, so that the
> real error can be propagated back to the user.
>
> - Use memcmp instead of strncmp.
>
> - Whitespace changes.
>
> What do you think?
>
> Rich.
Looks good to me. Thanks Rich.
eck
More information about the Libguestfs
mailing list