[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] p2v: wait for qemu-nbd before starting conversion (RHBZ#1167774)



"Richard W.M. Jones" <rjones redhat com> writes:
> Hi John,
>
> Looks good.  I've attached a slightly modified patch:
>
>  - Don't need to define the WAIT_* timeout in the header file.
>
>  - Call set_conversion_error in the subroutine, so that the
>    real error can be propagated back to the user.
>
>  - Use memcmp instead of strncmp.
>
>  - Whitespace changes.
>
> What do you think?
>
> Rich.

Looks good to me.  Thanks Rich.

eck


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]