[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] p2v: avoid connecting to ourself while probing qemu-nbd (RHBZ#1167774)



On Fri, Dec 12, 2014 at 12:10:06PM -0500, John Eckersberg wrote:
> +  if (bind (sockfd, (struct sockaddr *) &src_addr, sizeof src_addr) == -1) {
> +    perror ("bind");

This line needs to be:

    set_conversion_error ("waiting for qemu-nbd to start: bind: %m");

I'm trying to make the test hard to see if I can break this one too :-)

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]