[Libguestfs] [PATCH 1/8] builder: allow "no key" as key in Sigchecker

[Richard W.M. Jones]

On Tue, Feb 25, 2014 at 05:29:06PM +0100, Pino Toscano wrote:
> +  (* Make sure we have no check_signature=true with no actual key. *)
> +  let check_signature, gpgkey =
> +    match check_signature, gpgkey with
> +    | true, No_Key -> false, No_Key
> +    | x, y -> x, y in

Minor stylistic point: You can write the second case as:

  | x -> x in

It's also fractionally faster (not in this case, but if this was in an
inner loop) because it means the compiler doesn't have to cons a new
cell, it just returns the old one.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top